Discussion:
[webm-discuss] Issue 1448 in webm: low bd x86 quantize functions fail tests in high bd builds
johannko… via monorail
2017-07-20 15:12:54 UTC
Permalink
Status: Assigned
Owner: ***@google.com
Labels: Type-Bug Pri-2
Components: libvpx

New issue 1448 by ***@google.com: low bd x86 quantize functions
fail tests in high bd builds
https://bugs.chromium.org/p/webm/issues/detail?id=1448

../libvpx/configure --enable-vp9-highbitdepth

./test_libvpx --gtest_filter="*VP9QuantizeTest*"

SSE2, SSSE3, and AVX optimizations fail test with mismatch in dqcoeff
buffers

Note: Google Test filter = *AVX*VP9QuantizeTest*
[==========] Running 2 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 2 tests from AVX/VP9QuantizeTest
[ RUN ] AVX/VP9QuantizeTest.OperationCheck/0
../libvpx/test/vp9_quantize_test.cc:142: Failure
Value of: dqcoeff.CheckValues(ref_dqcoeff)
Actual: false
Expected: true
Failure on iteration 21.
<qcoeff matches>

<dqcoeff mismatch>
This buffer:
*-29752 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
Reference buffer:
*35784 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
[ FAILED ] AVX/VP9QuantizeTest.OperationCheck/0, where GetParam() =
(0x744c40, 0x656cb0, 8) (1 ms)
--
You received this message because:
1. The project was configured to send all issue notifications to this
address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings
--
You received this message because you are subscribed to the Google Groups "WebM Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to webm-discuss+***@webmproject.org.
To post to this group, send email to webm-***@webmproject.org.
Visit this group at https://groups.google.com/a/webmproject.org/group/webm-discuss/.
For more options, visit https://groups.google.com/a/webmproject.org/d/optout.
bugdro… via monorail
2017-07-20 19:46:10 UTC
Permalink
Comment #1 on issue 1448 by ***@chromium.org: low bd x86 quantize
functions fail tests in high bd builds
https://bugs.chromium.org/p/webm/issues/detail?id=1448#c1

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libvpx/+/c782f27ead354ae7fa4a40c5c679071ae9e8dd3b

commit c782f27ead354ae7fa4a40c5c679071ae9e8dd3b
Author: Johann <***@google.com>
Date: Thu Jul 20 15:17:48 2017

quantize test: lowbd functions do not pass in highbd

qcoeff output looks OK but dqcoeff is no good.

BUG=webm:1448

Change-Id: I07211db8a8b74f1f45fdd059852e2de0e5ee18fd

[modify]
https://crrev.com/c782f27ead354ae7fa4a40c5c679071ae9e8dd3b/test/vp9_quantize_test.cc
--
You received this message because:
1. The project was configured to send all issue notifications to this
address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings
--
You received this message because you are subscribed to the Google Groups "WebM Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to webm-discuss+***@webmproject.org.
To post to this group, send email to webm-***@webmproject.org.
Visit this group at https://groups.google.com/a/webmproject.org/group/webm-discuss/.
For more options, visit https://groups.google.com/a/webmproject.org/d/optout.
johannko… via monorail
2017-08-23 19:23:52 UTC
Permalink
Updates:
Cc: ***@google.com

Comment #3 on issue 1448 by ***@google.com: low bd x86 quantize
functions fail tests in high bd builds
https://bugs.chromium.org/p/webm/issues/detail?id=1448#c3

Issue 1458 has been merged into this issue.
--
You received this message because:
1. The project was configured to send all issue notifications to this
address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings
--
You received this message because you are subscribed to the Google Groups "WebM Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to webm-discuss+***@webmproject.org.
To post to this group, send email to webm-***@webmproject.org.
Visit this group at https://groups.google.com/a/webmproject.org/group/webm-discuss/.
For more options, visit https://groups.google.com/a/webmproject.org/d/optout.
bugdro… via monorail
2018-09-14 18:13:50 UTC
Permalink
Comment #4 on issue 1448 by ***@chromium.org: low bd x86 quantize
functions fail tests in high bd builds
https://bugs.chromium.org/p/webm/issues/detail?id=1448#c4

The following revision refers to this bug:

https://aomedia.googlesource.com/aom/+/89b4c615df2dc23ccfd625d2177b65d8616fdab6

commit 89b4c615df2dc23ccfd625d2177b65d8616fdab6
Author: Johann <***@duck.com>
Date: Fri Sep 14 18:13:08 2018

add quantize functions to tests

All the smaller (16x16) quantize tests pass. The larger ones do not but
we can get limited coverage by testing the ssse3 against the avx code.

Similar issue to libvpx:
BUG=webm:1448

Change-Id: Ide8a381a3898c12b6f9a033dc3c932c5df629514

[modify]
https://crrev.com/89b4c615df2dc23ccfd625d2177b65d8616fdab6/test/quantize_func_test.cc
--
You received this message because:
1. The project was configured to send all issue notifications to this
address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings
--
You received this message because you are subscribed to the Google Groups "WebM Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to webm-discuss+***@webmproject.org.
To post to this group, send email to webm-***@webmproject.org.
Visit this group at https://groups.google.com/a/webmproject.org/group/webm-discuss/.
For more options, visit https://groups.google.com/a/webmproject.org/d/optout.
bugdro… via monorail
2018-11-30 18:59:41 UTC
Permalink
Comment #5 on issue 1448 by ***@chromium.org: low bd x86 quantize
functions fail tests in high bd builds
https://bugs.chromium.org/p/webm/issues/detail?id=1448#c5

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libvpx/+/0eeb7975128997b3f978d3a6c81d6e25b4d4a8c9

commit 0eeb7975128997b3f978d3a6c81d6e25b4d4a8c9
Author: Johann <***@duck.com>
Date: Wed Nov 28 16:30:02 2018

quantize: fix x86 hbd builds

Calculate the high bits of dqcoeff in high bit depth builds and store
them appropriately.

BUG=webm:1448

Change-Id: I61a2f8bfcf2e30765f10a94073c4d58321d2fa24

[modify]
https://crrev.com/0eeb7975128997b3f978d3a6c81d6e25b4d4a8c9/vpx_dsp/x86/quantize_avx.c
[modify]
https://crrev.com/0eeb7975128997b3f978d3a6c81d6e25b4d4a8c9/vpx_dsp/x86/quantize_ssse3.c
[modify]
https://crrev.com/0eeb7975128997b3f978d3a6c81d6e25b4d4a8c9/test/vp9_quantize_test.cc
[modify]
https://crrev.com/0eeb7975128997b3f978d3a6c81d6e25b4d4a8c9/vpx_dsp/x86/quantize_sse2.c
[modify]
https://crrev.com/0eeb7975128997b3f978d3a6c81d6e25b4d4a8c9/vpx_dsp/x86/quantize_sse2.h
--
You received this message because:
1. The project was configured to send all issue notifications to this
address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings
--
You received this message because you are subscribed to the Google Groups "WebM Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to webm-discuss+***@webmproject.org.
To post to this group, send email to webm-***@webmproject.org.
Visit this group at https://groups.google.com/a/webmproject.org/group/webm-discuss/.
For more options, visit https://groups.google.com/a/webmproject.org/d/optout.
bugdro… via monorail
2018-11-30 18:59:42 UTC
Permalink
Comment #6 on issue 1448 by ***@chromium.org: low bd x86 quantize
functions fail tests in high bd builds
https://bugs.chromium.org/p/webm/issues/detail?id=1448#c6

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libvpx/+/d566160f32580e5ef8fccbce8dde8495756a0620

commit d566160f32580e5ef8fccbce8dde8495756a0620
Author: Johann <***@duck.com>
Date: Wed Nov 28 16:30:37 2018

quantize 32x32: fix dqcoeff

Calculate the high bits of dqcoeff and store them appropriately in high
bit depth builds.

Low bit depth builds still do not pass. C truncates the results after
division. X86 only supports packing with saturation at this step.

BUG=webm:1448

Change-Id: Ic80def575136c7ca37edf18d21e26925b475da98

[modify]
https://crrev.com/d566160f32580e5ef8fccbce8dde8495756a0620/vpx_dsp/x86/quantize_ssse3.c
[add]
https://crrev.com/d566160f32580e5ef8fccbce8dde8495756a0620/vpx_dsp/x86/quantize_ssse3.h
[modify]
https://crrev.com/d566160f32580e5ef8fccbce8dde8495756a0620/vpx_dsp/x86/quantize_avx.c
[modify]
https://crrev.com/d566160f32580e5ef8fccbce8dde8495756a0620/test/vp9_quantize_test.cc
[modify]
https://crrev.com/d566160f32580e5ef8fccbce8dde8495756a0620/vpx_dsp/vpx_dsp.mk
[modify]
https://crrev.com/d566160f32580e5ef8fccbce8dde8495756a0620/vpx_dsp/x86/quantize_sse2.h
--
You received this message because:
1. The project was configured to send all issue notifications to this
address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings
--
You received this message because you are subscribed to the Google Groups "WebM Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to webm-discuss+***@webmproject.org.
To post to this group, send email to webm-***@webmproject.org.
Visit this group at https://groups.google.com/a/webmproject.org/group/webm-discuss/.
For more options, visit https://groups.google.com/a/webmproject.org/d/optout.
bugdro… via monorail
2018-12-03 17:40:06 UTC
Permalink
Comment #7 on issue 1448 by ***@chromium.org: low bd x86 quantize
functions fail tests in high bd builds
https://bugs.chromium.org/p/webm/issues/detail?id=1448#c7

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libvpx/+/5fbc7a286b4d72883392fdbb10ec52bace662f66

commit 5fbc7a286b4d72883392fdbb10ec52bace662f66
Author: Johann <***@duck.com>
Date: Sat Dec 01 00:27:14 2018

quantize 32x32: saturate dqcoeff on x86

This slows down low bitdepth builds but is necessary to obtain correct
values.

BUG=webm:1448

Change-Id: I4ca9145f576089bb8496fcfeedeb556dc8fe6574

[modify]
https://crrev.com/5fbc7a286b4d72883392fdbb10ec52bace662f66/vpx_dsp/quantize.c
[modify]
https://crrev.com/5fbc7a286b4d72883392fdbb10ec52bace662f66/test/vp9_quantize_test.cc
[modify]
https://crrev.com/5fbc7a286b4d72883392fdbb10ec52bace662f66/vpx_dsp/x86/quantize_ssse3.h
--
You received this message because:
1. The project was configured to send all issue notifications to this
address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings
--
You received this message because you are subscribed to the Google Groups "WebM Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to webm-discuss+***@webmproject.org.
To post to this group, send email to webm-***@webmproject.org.
Visit this group at https://groups.google.com/a/webmproject.org/group/webm-discuss/.
For more options, visit https://groups.google.com/a/webmproject.org/d/optout.
bugdro… via monorail
2018-12-05 18:20:36 UTC
Permalink
Comment #8 on issue 1448 by ***@chromium.org: low bd x86 quantize
functions fail tests in high bd builds
https://bugs.chromium.org/p/webm/issues/detail?id=1448#c8

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libvpx/+/26dbf9eba8cbbd0d57a87525ff28103dac229325

commit 26dbf9eba8cbbd0d57a87525ff28103dac229325
Author: Johann <***@duck.com>
Date: Mon Dec 03 18:55:00 2018

quantize neon: fix hbd builds

BUG=webm:1448

Change-Id: I2140fb9b6ce92716d2d9509f3031244088a62127

[modify]
https://crrev.com/26dbf9eba8cbbd0d57a87525ff28103dac229325/test/vp9_quantize_test.cc
[modify]
https://crrev.com/26dbf9eba8cbbd0d57a87525ff28103dac229325/vpx_dsp/arm/quantize_neon.c
--
You received this message because:
1. The project was configured to send all issue notifications to this
address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings
--
You received this message because you are subscribed to the Google Groups "WebM Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to webm-discuss+***@webmproject.org.
To post to this group, send email to webm-***@webmproject.org.
Visit this group at https://groups.google.com/a/webmproject.org/group/webm-discuss/.
For more options, visit https://groups.google.com/a/webmproject.org/d/optout.
johannko… via monorail
2018-12-05 18:21:10 UTC
Permalink
Updates:
Status: Fixed

Comment #9 on issue 1448 by ***@google.com: low bd x86 quantize
functions fail tests in high bd builds
https://bugs.chromium.org/p/webm/issues/detail?id=1448#c9

(No comment was entered for this change.)
--
You received this message because:
1. The project was configured to send all issue notifications to this
address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings
--
You received this message because you are subscribed to the Google Groups "WebM Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to webm-discuss+***@webmproject.org.
To post to this group, send email to webm-***@webmproject.org.
Visit this group at https://groups.google.com/a/webmproject.org/group/webm-discuss/.
For more options, visit https://groups.google.com/a/webmproject.org/d/optout.
Loading...