[webm-discuss] Issue 1578 in webm: Partition scaling for SVC crashes

Discussion:

ji… via monorail

2018-11-20 20:28:16 UTC

Status: Assigned
Owner: ***@google.com
CC: ***@google.com
Labels: Type-Bug Pri-2
Components: libvpx

New issue 1578 by ***@google.com: Partition scaling for SVC crashes
https://bugs.chromium.org/p/webm/issues/detail?id=1578

Can you reproduce using the vpxdec or vpxenc tools? What command line are
you using?
examples/vp9_spatial_svc_encoder -w 1920 -h 1080 -t 1/30 -sl 3 -bl
50,100,200,200,300,400,400,600,800 -b 1400 -k 10000 --rc-end-usage=1
--lag-in-frames=0 --passes=1 --speed=7 --threads=1
--temporal-layering-mode=3 -aq 1 --drop-frame=0 --tune-content=1 -f 500
~/VideoClips/1080p/slides_code_term_web_plot_1920x1080.yuv out.webm

Please provide any additional information below.
#0 0x0000555555676280 in update_prev_partition_helper (cpi=0x7ffff7edb020,
bsize=6 '\006', mi_row=134, mi_col=64) at vp9/encoder/vp9_encodeframe.c:1074
#1 0x0000555555676413 in update_prev_partition_helper (cpi=0x7ffff7edb020,
bsize=9 '\t', mi_row=132, mi_col=64) at vp9/encoder/vp9_encodeframe.c:1093
#2 0x0000555555676413 in update_prev_partition_helper (cpi=0x7ffff7edb020,
bsize=12 '\f', mi_row=128, mi_col=64) at vp9/encoder/vp9_encodeframe.c:1093
#3 0x0000555555676491 in update_prev_partition (cpi=0x7ffff7edb020,
x=0x7ffff7ee7020, segment_id=0, mi_row=128, mi_col=64, sb_offset=504) at
vp9/encoder/vp9_encodeframe.c:1103
#4 0x0000555555676d44 in choose_partitioning (cpi=0x7ffff7edb020,
tile=0x555555ea4ff0, x=0x7ffff7ee7020, mi_row=128, mi_col=64) at
vp9/encoder/vp9_encodeframe.c:1281
#5 0x0000555555686045 in encode_nonrd_sb_row (cpi=0x7ffff7edb020,
td=0x7ffff7ee7020, tile_data=0x555555ea4ff0, mi_row=128, tp=0x7fffffffb2e0)
at vp9/encoder/vp9_encodeframe.c:5310
#6 0x0000555555686f61 in vp9_encode_sb_row (cpi=0x7ffff7edb020,
td=0x7ffff7ee7020, tile_row=0, tile_col=0, mi_row=128) at
vp9/encoder/vp9_encodeframe.c:5596
#7 0x00005555556871bb in vp9_encode_tile (cpi=0x7ffff7edb020,
td=0x7ffff7ee7020, tile_row=0, tile_col=0) at
vp9/encoder/vp9_encodeframe.c:5621
#8 0x000055555568724f in encode_tiles (cpi=0x7ffff7edb020) at
vp9/encoder/vp9_encodeframe.c:5634
#9 0x0000555555687979 in encode_frame_internal (cpi=0x7ffff7edb020) at
vp9/encoder/vp9_encodeframe.c:5769
#10 0x00005555556882bf in vp9_encode_frame (cpi=0x7ffff7edb020) at
vp9/encoder/vp9_encodeframe.c:5988
#11 0x000055555559fcf8 in encode_without_recode_loop (cpi=0x7ffff7edb020,
size=0x7fffffffb860,

dest=0x7fffeaeea7ea "\035U\361\221\213\277\300\004\266C\v\240W\f\362\330xÆz^\333\342R\200a\200U\037p\205\020\356\360#\266\234\341i\205\224\364\271Þ0\363:24ÈŸ\360\300\***@R\307\355:")
at vp9/encoder/vp9_encoder.c:3940
#12 0x00005555555a13ce in encode_frame_to_data_rate (cpi=0x7ffff7edb020,
size=0x7fffffffb860,

dest=0x7fffeaeea7ea "\035U\361\221\213\277\300\004\266C\v\240W\f\362\330xÆz^\333\342R\200a\200U\037p\205\020\356\360#\266\234\341i\205\224\364\271Þ0\363:24ÈŸ\360\300\***@R\307\355:",
frame_flags=0x7fffffffb87c) at vp9/encoder/vp9_encoder.c:4768
#13 0x00005555555a1af2 in SvcEncode (cpi=0x7ffff7edb020,
size=0x7fffffffb860,

dest=0x7fffeaeea7ea "\035U\361\221\213\277\300\004\266C\v\240W\f\362\330xÆz^\333\342R\200a\200U\037p\205\020\356\360#\266\234\341i\205\224\364\271Þ0\363:24ÈŸ\360\300\***@R\307\355:",
frame_flags=0x7fffffffb87c) at vp9/encoder/vp9_encoder.c:4952
#14 0x00005555555a58d2 in vp9_get_compressed_data (cpi=0x7ffff7edb020,
frame_flags=0x7fffffffb87c, size=0x7fffffffb860,

dest=0x7fffeaeea7ea "\035U\361\221\213\277\300\004\266C\v\240W\f\362\330xÆz^\333\342R\200a\200U\037p\205\020\356\360#\266\234\341i\205\224\364\271Þ0\363:24ÈŸ\360\300\***@R\307\355:",
time_stamp=0x7fffffffb870, time_end=0x7fffffffb868, flush=0) at
vp9/encoder/vp9_encoder.c:6691
#15 0x0000555555594237 in encoder_encode (ctx=0x555555a41a20,
img=0x7fffffffce00, pts=1, duration=1, enc_flags=0, deadline=1) at
vp9/vp9_cx_iface.c:1192
#16 0x0000555555560c8c in vpx_codec_encode (ctx=0x7fffffffd060,
img=0x7fffffffce00, pts=1, duration=1, flags=0, deadline=1) at
vpx/src/vpx_encoder.c:214
#17 0x000055555555c4b6 in vpx_svc_encode (svc_ctx=0x7fffffffceb0,
codec_ctx=0x7fffffffd060, rawimg=0x7fffffffce00, pts=1, duration=1,
deadline=1)
at examples/svc_encodeframe.c:542
#18 0x000055555555fcd7 in main (argc=29, argv=0x7fffffffd378) at
examples/vp9_spatial_svc_encoder.c:953
--
You received this message because:
1. The project was configured to send all issue notifications to this
address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

--
You received this message because you are subscribed to the Google Groups "WebM Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to webm-discuss+***@webmproject.org.
To post to this group, send email to webm-***@webmproject.org.
Visit this group at https://groups.google.com/a/webmproject.org/group/webm-discuss/.
For more options, visit https://groups.google.com/a/webmproject.org/d/optout.

bugdro… via monorail

2018-11-20 22:07:02 UTC

Permalink

Comment #1 on issue 1578 by ***@chromium.org: Partition scaling for
SVC crashes
https://bugs.chromium.org/p/webm/issues/detail?id=1578#c1

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libvpx/+/e6332e04f20277de7db0314f95a0d8f6a841f10d

commit e6332e04f20277de7db0314f95a0d8f6a841f10d
Author: Jerome Jiang <***@google.com>
Date: Tue Nov 20 20:29:51 2018

Disable partition scaling on 1080p and above.

BUG=webm:1578
Change-Id: I7c8014b7ab96d372d486433bce24d058a60fdc85

[modify]
https://crrev.com/e6332e04f20277de7db0314f95a0d8f6a841f10d/vp9/encoder/vp9_speed_features.c
--
You received this message because:
1. The project was configured to send all issue notifications to this
address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

bugdro… via monorail

2018-11-27 04:49:01 UTC

Permalink

Comment #2 on issue 1578 by ***@chromium.org: Partition scaling for
SVC crashes
https://bugs.chromium.org/p/webm/issues/detail?id=1578#c2

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libvpx/+/545f096ef23d4f70062379d9c4184b15189c2143

commit 545f096ef23d4f70062379d9c4184b15189c2143
Author: Jerome Jiang <***@google.com>
Date: Tue Nov 27 02:34:12 2018

VP9 SVC: fix crash on scaling partition.

When scaling up partition from lower resolution layer L, mi_row and
mi_col from L must be smaller than mi_rows and mi_cols from L.

Before this change, the condition was based on mi_rows from top layer
divided by 2, which is not necessarily equal to the mi_rows from lower
resolution layer.

Added variable in SVC structure to keep track of mi_rows and mi_cols
from each spatial layer.

Re-enable partition scaling for 1080p.

BUG=webm:1578

Change-Id: Icc1c701b095cfe0a92bfecca1ed39dbe21da12b6

[modify]
https://crrev.com/545f096ef23d4f70062379d9c4184b15189c2143/vp9/encoder/vp9_encodeframe.c
[modify]
https://crrev.com/545f096ef23d4f70062379d9c4184b15189c2143/vp9/encoder/vp9_svc_layercontext.c
[modify]
https://crrev.com/545f096ef23d4f70062379d9c4184b15189c2143/vp9/encoder/vp9_svc_layercontext.h
[modify]
https://crrev.com/545f096ef23d4f70062379d9c4184b15189c2143/vp9/encoder/vp9_speed_features.c
--
You received this message because:
1. The project was configured to send all issue notifications to this
address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

ji… via monorail

2018-11-27 07:28:34 UTC

Permalink

Updates:
Cc: ***@google.com

Comment #3 on issue 1578 by ***@google.com: Partition scaling for SVC
crashes
https://bugs.chromium.org/p/webm/issues/detail?id=1578#c3

This should be fixed by now. I'll keep this issue open till I add test for
this. But 1080p clip needs to be added to test vector.
--
You received this message because:
1. The project was configured to send all issue notifications to this
address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings